greg/hanoidb
1
0
Fork 0
Code Issues 10 Pull requests 3 Projects Releases Packages Wiki Activity

Please add "deps" in the default command for "make" #29

New issue
Closed
opened 2014-11-18 13:35:43 +00:00 by essen · 6 comments
essen commented 2014-11-18 13:35:43 +00:00 (Migrated from github.com)
Copy link

The recommended default behavior for a Makefile is to build everything, not just one part of the project. The lack of "deps" in the default target means erlang.mk fails to properly build hanoidb when used as a dependency.

Initial report here: https://github.com/ninenines/erlang.mk/issues/163

I can send a patch if you want, I just want to get an OK on this first.

The recommended default behavior for a Makefile is to build everything, not just one part of the project. The lack of "deps" in the default target means erlang.mk fails to properly build hanoidb when used as a dependency. Initial report here: https://github.com/ninenines/erlang.mk/issues/163 I can send a patch if you want, I just want to get an OK on this first.
krestenkrab commented 2014-11-18 20:56:15 +00:00 (Migrated from github.com)
Copy link

How about this?

How about this?
krestenkrab commented 2014-11-18 21:06:13 +00:00 (Migrated from github.com)
Copy link

@brigadier does this fix your issue?

@brigadier does this fix your issue?
essen commented 2014-11-18 21:13:38 +00:00 (Migrated from github.com)
Copy link

Hope the tests don't take too long if you put them there. :-)

To take example for GNU for example, the default target only does the building, then all the tests and other checks is done in "check". (Typical process is "make" then "make check" and then "make install") Other standards follow a similar pattern.

Hope the tests don't take too long if you put them there. :-) To take example for GNU for example, the default target only does the building, then all the tests and other checks is done in "check". (Typical process is "make" then "make check" and then "make install") Other standards follow a similar pattern.
krestenkrab commented 2014-11-18 23:04:34 +00:00 (Migrated from github.com)
Copy link

I can leave out the tests... They do take a while.

I can leave out the tests... They do take a while.
essen commented 2014-11-19 08:46:38 +00:00 (Migrated from github.com)
Copy link

Looks good, thanks!

Looks good, thanks!
essen commented 2014-11-19 08:53:35 +00:00 (Migrated from github.com)
Copy link

Took this opportunity to add hanoidb to the erlang.mk index. Now people only need to put "DEPS = hanoidb" in their makefile and to have rebar installed as you don't include it in the repository.

Took this opportunity to add hanoidb to the erlang.mk index. Now people only need to put "DEPS = hanoidb" in their makefile and to have rebar installed as you don't include it in the repository.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
krab-improve-specs
krab-backend-api
krab-add-expiry
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: greg/hanoidb#29
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?