greg/hanoidb
1
0
Fork 0
Code Issues 10 Pull requests 3 Projects Releases Packages Wiki Activity

Fixing the building of hanoidb for R18 #37

Merged
a13x merged 1 commit from master into master 2016-03-26 01:03:12 +00:00
Conversation 4 Commits 1 Files changed 5 +39 -7
a13x commented 2016-03-21 12:27:17 +00:00 (Migrated from github.com)
Copy link

Some of the dependencies are broken and type definitions are no longer valid for R18.

Fix sext and edown dependency
Fix array() type defs

Change-Id: Ibc2986b690fb81ef9d757fa7b8ba20a994bc8fa2

Some of the dependencies are broken and type definitions are no longer valid for R18. Fix sext and edown dependency Fix array() type defs Change-Id: Ibc2986b690fb81ef9d757fa7b8ba20a994bc8fa2
krestenkrab commented 2016-03-21 12:32:45 +00:00 (Migrated from github.com)
Copy link

Any hints for how to fix this across erlang releases? The array() types doesn't work for old types. A macro perhaps?

https://travis-ci.org/krestenkrab/hanoidb/builds/117436445

You should also update the .travis file to include R18.

Any hints for how to fix this across erlang releases? The array() types doesn't work for old types. A macro perhaps? https://travis-ci.org/krestenkrab/hanoidb/builds/117436445 You should also update the .travis file to include R18.
a13x commented 2016-03-23 10:45:08 +00:00 (Migrated from github.com)
Copy link

Yeah, I'm going to redo this PR to include R18 for travis and workout how it would work across releases.. Sorry for a hastily sent PR :)

Yeah, I'm going to redo this PR to include R18 for travis and workout how it would work across releases.. Sorry for a hastily sent PR :)
a13x commented 2016-03-23 14:28:05 +00:00 (Migrated from github.com)
Copy link

I used rebar's platform_depend trickery.. builds work now, feel free to review! :)

I used rebar's platform_depend trickery.. builds work now, feel free to review! :)
krestenkrab commented 2016-03-26 01:03:44 +00:00 (Migrated from github.com)
Copy link

Superb. Thanks @a13x!

Superb. Thanks @a13x!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: greg/hanoidb#37
No description provided.
Delete branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?