From 895921c598a0c6820be875c956a26007ee5558f4 Mon Sep 17 00:00:00 2001 From: Greg Burd Date: Thu, 14 Sep 2017 13:16:06 -0400 Subject: [PATCH] Another spot I missed allowing null UOW in {a}sync(). --- pom.xml | 2 +- .../java/net/helenus/core/operation/AbstractOperation.java | 4 ++-- src/main/java/net/helenus/core/operation/Operation.java | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/pom.xml b/pom.xml index 5748c69..593aa4e 100644 --- a/pom.xml +++ b/pom.xml @@ -5,7 +5,7 @@ 4.0.0 net.helenus helenus-core - 2.0.35-SNAPSHOT + 2.0.36-SNAPSHOT jar helenus diff --git a/src/main/java/net/helenus/core/operation/AbstractOperation.java b/src/main/java/net/helenus/core/operation/AbstractOperation.java index d967c1c..46739b9 100644 --- a/src/main/java/net/helenus/core/operation/AbstractOperation.java +++ b/src/main/java/net/helenus/core/operation/AbstractOperation.java @@ -52,7 +52,7 @@ public abstract class AbstractOperation> } public E sync(UnitOfWork uow) { - Objects.requireNonNull(uow, "Unit of Work should not be null."); + if (uow == null) return sync(); final Timer.Context context = requestLatency.time(); try { @@ -69,7 +69,7 @@ public abstract class AbstractOperation> } public CompletableFuture async(UnitOfWork uow) { - Objects.requireNonNull(uow, "Unit of Work should not be null."); + if (uow == null) return async(); return CompletableFuture.supplyAsync(() -> sync(uow)); } diff --git a/src/main/java/net/helenus/core/operation/Operation.java b/src/main/java/net/helenus/core/operation/Operation.java index fb7d4a6..d349ada 100644 --- a/src/main/java/net/helenus/core/operation/Operation.java +++ b/src/main/java/net/helenus/core/operation/Operation.java @@ -26,9 +26,9 @@ public abstract class Operation { Operation(AbstractSessionOperations sessionOperations) { this.sessionOps = sessionOperations; MetricRegistry metrics = sessionOperations.getMetricRegistry(); - this.uowCacheHits = metrics.meter("helenus.UOW-cache-hits"); - this.uowCacheMiss = metrics.meter("helenus.UOW-cache-miss"); - this.requestLatency = metrics.timer("helenus.request-latency"); + this.uowCacheHits = metrics.meter("net.helenus.UOW-cache-hits"); + this.uowCacheMiss = metrics.meter("net.helenus.UOW-cache-miss"); + this.requestLatency = metrics.timer("net.helenus.request-latency"); } public ResultSet execute(AbstractSessionOperations session, UnitOfWork uow, TraceContext traceContext, boolean showValues, boolean cached) {