From 48e82ac1a4fc8cdd1e549817838737209ddb89b1 Mon Sep 17 00:00:00 2001 From: Scott Lystig Fritchie Date: Fri, 14 Aug 2015 22:29:20 +0900 Subject: [PATCH] WIP: use digraph to calculate better AllHosed --- src/machi_chain_manager1.erl | 39 ++++++++++++++++++++++++++++++++++-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/src/machi_chain_manager1.erl b/src/machi_chain_manager1.erl index 731d1da..cda7cd6 100644 --- a/src/machi_chain_manager1.erl +++ b/src/machi_chain_manager1.erl @@ -1943,9 +1943,17 @@ calculate_flaps(P_newprop, _P_current, _FlapLimit, %% magically knows about both problem FLUs. Weird/cool. AllFlapCounts = TempAllFlapCounts, + HosedTransUnionTs = [T || T <- HosedTransUnion, is_tuple(T)], AnnotatedBadFLUs = [{MyName, problem_with, FLU} || FLU <- BadFLUs], - AllHosed = lists:usort(DownUnion ++ HosedTransUnion ++ BadFLUs ++ - AnnotatedBadFLUs); + HosedAnnotations = lists:usort(HosedTransUnionTs ++ AnnotatedBadFLUs), + Magic = lists:sort( + digraph_magic(P_newprop#projection_v1.all_members, + HosedAnnotations)), + AllHosed = lists:usort(HosedAnnotations ++ Magic), + io:format(user, "ALLHOSED ~p: ~p ~p\n", [MyName, Magic, HosedAnnotations]), + AllHosed; + %% AllHosed = lists:usort(DownUnion ++ HosedTransUnion ++ BadFLUs ++ + %% AnnotatedBadFLUs); {_N, _} -> NewFlaps = 0, NewFlapStart = ?NOT_FLAPPING_START, @@ -2841,3 +2849,30 @@ perhaps_verbose_c110(P_latest2, S) -> _ -> ok end. + +digraph_magic(All_list, HosedAnnotations) -> + G = digraph:new(), + [digraph:add_vertex(G, V) || V <- All_list], + [digraph:add_edge(G, V1, V2) || {V1, problem_with, V2} <- HosedAnnotations], + calc_magic_down(lists:sort(digraph:vertices(G)), G). + +calc_magic_down([], G) -> + digraph:delete(G), + []; +calc_magic_down([H|T], G) -> + case digraph:in_degree(G, H) of + 0 -> + calc_magic_down(T, G); + 1 -> + Neighbors = digraph:in_neighbours(G, H), + case [V || V <- Neighbors, digraph:in_degree(G, V) == 1] of + [AlsoOne|_] -> + %% TODO: be smarter here about the choice of which is down. + [H|calc_magic_down(T -- [AlsoOne], G)]; + [] -> + %% H is "on the end", e.g. 1-2-1, so it's OK. + calc_magic_down(T, G) + end; + N when N > 1 -> + [H|calc_magic_down(T, G)] + end.