diff --git a/dialyzer.ignore-warnings b/dialyzer.ignore-warnings index 599eed8..db73995 100644 --- a/dialyzer.ignore-warnings +++ b/dialyzer.ignore-warnings @@ -1 +1,14 @@ +### The auto-generated code of machi_pb.beam has some complaints, not fixed yet. +machi_pb.erl:0: +################################################## +######## Specific types ##################### +################################################## + basho_bench_config:get/2 + machi_partition_simulator:get/1 +################################################## +######## Specific messages ##################### +################################################## machi_chain_manager1.erl:2473: The created fun has no local return +machi_chain_manager1.erl:2102: The pattern <_P1, P2, Else = {'expected_author2', UPI1_tail, _}> can never match the type <#projection_v1{epoch_number::'undefined' | non_neg_integer(),epoch_csum::'undefined' | binary(),author_server::atom() | binary(),all_members::'undefined' | [atom() | binary()],witnesses::[atom() | binary()],creation_time::'undefined' | {non_neg_integer(),non_neg_integer(),non_neg_integer()},mode::'ap_mode' | 'cp_mode',upi::'undefined' | [atom() | binary()],repairing::'undefined' | [atom() | binary()],down::'undefined' | [atom() | binary()],dbg::'undefined' | [any()],dbg2::'undefined' | [any()],members_dict::'undefined' | [{_,_}]},#projection_v1{epoch_number::'undefined' | non_neg_integer(),epoch_csum::binary(),author_server::atom() | binary(),all_members::'undefined' | [atom() | binary()],witnesses::[atom() | binary()],creation_time::'undefined' | {non_neg_integer(),non_neg_integer(),non_neg_integer()},mode::'ap_mode' | 'cp_mode',upi::'undefined' | [atom() | binary()],repairing::'undefined' | [atom() | binary()],down::'undefined' | [atom() | binary()],dbg::'undefined' | [any()],dbg2::'undefined' | [any()],members_dict::'undefined' | [{_,_}]},'true'> +machi_chain_manager1.erl:2151: The pattern <_P1 = {'projection_v1', _, _, _, _, _, _, 'cp_mode', UPI1, Repairing1, _, _, _, _}, _P2 = {'projection_v1', _, _, _, _, _, _, 'cp_mode', UPI2, Repairing2, _, _, _, _}, Else = {'epoch_not_si', EpochX, 'not_gt', EpochY}> can never match the type <#projection_v1{epoch_number::'undefined' | non_neg_integer(),epoch_csum::'undefined' | binary(),author_server::atom() | binary(),all_members::'undefined' | [atom() | binary()],witnesses::[atom() | binary()],creation_time::'undefined' | {non_neg_integer(),non_neg_integer(),non_neg_integer()},mode::'ap_mode' | 'cp_mode',upi::'undefined' | [atom() | binary()],repairing::'undefined' | [atom() | binary()],down::'undefined' | [atom() | binary()],dbg::'undefined' | [any()],dbg2::'undefined' | [any()],members_dict::'undefined' | [{_,_}]},#projection_v1{epoch_number::'undefined' | non_neg_integer(),epoch_csum::binary(),author_server::atom() | binary(),all_members::'undefined' | [atom() | binary()],witnesses::[atom() | binary()],creation_time::'undefined' | {non_neg_integer(),non_neg_integer(),non_neg_integer()},mode::'ap_mode' | 'cp_mode',upi::'undefined' | [atom() | binary()],repairing::'undefined' | [atom() | binary()],down::'undefined' | [atom() | binary()],dbg::'undefined' | [any()],dbg2::'undefined' | [any()],members_dict::'undefined' | [{_,_}]},'true'> +machi_flu1.erl:246: The created fun has no local return diff --git a/src/machi_flu1.erl b/src/machi_flu1.erl index 88a3b6d..370271f 100644 --- a/src/machi_flu1.erl +++ b/src/machi_flu1.erl @@ -241,7 +241,7 @@ append_server_loop(FluPid, #state{wedged=Wedged_p, {seq_append, From, Prefix, Chunk, CSum, Extra, EpochID} -> %% Old is the one from our state, plain old 'EpochID' comes %% from the client. - case OldEpochId == EpochID of + _ = case OldEpochId == EpochID of true -> spawn(fun() -> append_server_dispatch(From, Prefix, Chunk, CSum, Extra, FluName, EpochID) @@ -381,7 +381,7 @@ do_pb_ll_request2(EpochID, CMD, S) -> true -> %% We're at same epoch # but different checksum, or %% we're at a newer/bigger epoch #. - wedge_myself(S#state.flu_name, CurrentEpochID), + _ = wedge_myself(S#state.flu_name, CurrentEpochID), ok end, {{error, bad_epoch}, S#state{epoch_id=CurrentEpochID}}; diff --git a/src/machi_yessir_client.erl b/src/machi_yessir_client.erl index a7cb75d..f37b618 100644 --- a/src/machi_yessir_client.erl +++ b/src/machi_yessir_client.erl @@ -450,18 +450,18 @@ connect(#p_srvr{name=Name, props=Props})-> chunk_size=ChunkSize }, %% Add fake dict entries for these files - [begin - Prefix = list_to_binary(io_lib:format("fake~w", [X])), - {ok, _} = append_chunk_extra(Sock, {1,<<"unused">>}, Prefix, <<>>, FileSize) - end || X <- lists:seq(1, NumFiles)], + _ = [begin + Prefix = list_to_binary(io_lib:format("fake~w", [X])), + {ok, _} = append_chunk_extra(Sock, {1,<<"unused">>}, Prefix, <<>>, FileSize) + end || X <- lists:seq(1, NumFiles)], Sock. disconnect(#yessir{name=Name}) -> - [erase(K) || {{N,offset,_}=K, _V} <- get(), N == Name], - [erase(K) || {{N,chunk,_}=K, _V} <- get(), N == Name], - [erase(K) || {{N,csum,_}=K, _V} <- get(), N == Name], - [erase(K) || {{N,proj,_,_}=K, _V} <- get(), N == Name], + _ = [erase(K) || {{N,offset,_}=K, _V} <- get(), N == Name], + _ = [erase(K) || {{N,chunk,_}=K, _V} <- get(), N == Name], + _ = [erase(K) || {{N,csum,_}=K, _V} <- get(), N == Name], + _ = [erase(K) || {{N,proj,_,_}=K, _V} <- get(), N == Name], ok. %% Example use: