greg/machi
1
0
Fork 0
Code Issues 11 Pull requests 1 Projects Releases Packages Wiki Activity Actions

TODO MARK todo comment and bugfix for machi_cr_client_test

Browse source
This commit is contained in:
Scott Lystig Fritchie 2015-10-12 15:30:37 +09:00
parent cbf773215e
commit 777909b0f5
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/machi_flu_metadata_mgr.erl
View file

@ -193,7 +193,15 @@ compute_hash(Data) ->
compute_worker(Hash) -> compute_worker(Hash) ->
MgrCount = get_env(metadata_manager_count, ?MAX_MGRS), MgrCount = get_env(metadata_manager_count, ?MAX_MGRS),
Hash rem MgrCount. (Hash rem MgrCount) + 1.
%% TODO MARK: Hrm, the intermittent failures of both of the tests
%% in machi_cr_client_test.erl were due to this func returning 0.
%% But machi_flu_metadata_mgr_sup:init() doesn't make a child with N=0.
%%
%% The remaining puzzle for me, which I'm now punting to you, sorry,
%% is why those two tests would sometimes pass, which implies to me that
%% sometimes the code path used by those tests never chooses worker 0
%% and occasionally it does choose worker 0.
get_manager_atom(FluName, Data) -> get_manager_atom(FluName, Data) ->
build_metadata_mgr_name(FluName, compute_worker(compute_hash(Data))). build_metadata_mgr_name(FluName, compute_worker(compute_hash(Data))).