greg/machi
1
0
Fork 0
Code Issues 11 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Allow read_chunk() to return partial chunks #18

Merged
kuenishi merged 2 commits from ku/read-all-valid-chunks into master 2015-10-19 07:25:43 +00:00
Conversation 1 Commits 2 Files changed 15 +197 -129
kuenishi commented 2015-10-19 06:42:02 +00:00 (Migrated from github.com)
Copy link

This is simply a change of read_chunk() protocol, where a response of
read_chunk() becomes list of written bytes along with checksum. All
related code including repair is changed as such. This is to pass all
tests and not actually supporting partial chunks.

This is a part of yak shaving for adding trim command regarding a comment in #14.

This is simply a change of read_chunk() protocol, where a response of read_chunk() becomes list of written bytes along with checksum. All related code including repair is changed as such. This is to pass all tests and not actually supporting partial chunks. This is a part of yak shaving for adding trim command regarding [a comment](https://github.com/basho/machi/pull/14#discussion_r42221952) in #14.
slfritchie commented 2015-10-19 07:25:22 +00:00 (Migrated from github.com)
Copy link

The PB API changes look good, with the understanding that the trimmed/unwritten distinction will be added in another PR. The eunit tests pass, yay.

The PB API changes look good, with the understanding that the trimmed/unwritten distinction will be added in another PR. The eunit tests pass, yay.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: greg/machi#18
No description provided.
Delete branch "ku/read-all-valid-chunks"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?