Regenerate checksum when chunks are to be sliced #27

Merged
kuenishi merged 5 commits from ku/border-checksum into master 2015-10-27 03:51:02 +00:00
kuenishi commented 2015-10-23 08:34:29 +00:00 (Migrated from github.com)
No description provided.
kuenishi commented 2015-10-23 10:36:36 +00:00 (Migrated from github.com)

This GH ticket is probably not a good long-term place.

Exactly. I tried to describe the definition in a @doc manner in machi_util.erl and machi_dt.erl in the last commit push 0e4ae81 . As well as I defined macros of atoms to avoid typo bug (I made so many bugs with atom typo).

> This GH ticket is probably not a good long-term place. Exactly. I tried to describe the definition in a `@doc` manner in `machi_util.erl` and `machi_dt.erl` in the last commit push 0e4ae81 . As well as I defined macros of atoms to avoid typo bug (I made so many bugs with atom typo).
slfritchie commented 2015-10-27 03:34:57 +00:00 (Migrated from github.com)

Hm.

==> machi (dialyzer)
machi_file_proxy.erl:665: The pattern <[], _, _> can never match the type <[any(),...],non_neg_integer(),non_neg_integer()>
Hm. ``` ==> machi (dialyzer) machi_file_proxy.erl:665: The pattern <[], _, _> can never match the type <[any(),...],non_neg_integer(),non_neg_integer()> ```
slfritchie commented 2015-10-27 03:50:59 +00:00 (Migrated from github.com)

Two compiler & Dialyzer warnings fixed. +1, thanks!

Two compiler & Dialyzer warnings fixed. +1, thanks!
kuenishi commented 2015-10-27 04:19:19 +00:00 (Migrated from github.com)

Oh, sorry. I'll keep running dialyzer next time.

Oh, sorry. I'll keep running dialyzer next time.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: greg/machi#27
No description provided.