greg/machi
1
0
Fork 0
Code Issues 11 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Add missing test cleanups #40

Merged
shino merged 3 commits from ss/missing-test-cleanups into master 2015-11-05 07:16:40 +00:00
Conversation 2 Commits 3 Files changed 4 +28 -14
shino commented 2015-11-05 03:01:03 +00:00 (Migrated from github.com)
Copy link

Add missing cleanup codes for AP-mode repair eqc. Without it, it made other test cases fail (depending on execution order.) The cleanup includes process termination in #state of the test, which mitigates process leak memtioned at [1] but does not solve completely.

Also it adds -v flag to rebar eunit command

[1] https://github.com/basho/machi/issues/37#issuecomment-152521760

Add missing cleanup codes for AP-mode repair eqc. Without it, it made other test cases fail (depending on execution order.) The cleanup includes process termination in `#state` of the test, which mitigates process leak memtioned at [1] but does not solve completely. Also it adds `-v` flag to `rebar eunit` command [1] https://github.com/basho/machi/issues/37#issuecomment-152521760
kuenishi commented 2015-11-05 07:16:36 +00:00 (Migrated from github.com)
Copy link

+1, great work as always.

+1, great work as always.
jadeallenx commented 2015-11-05 16:40:46 +00:00 (Migrated from github.com)
Copy link

@shino Awesome work! 🐹

@shino Awesome work! :hamster:
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: greg/machi#40
No description provided.
Delete branch "ss/missing-test-cleanups"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?