Issues from PR #35 #41

New issue

Open

opened 2015-11-05 16:44:41 +00:00 by jadeallenx · 1 comment

jadeallenx commented

2015-11-05 16:44:41 +00:00

(Migrated from github.com)

From PR #35

Are filenames in PB high clients string()?
- https://github.com/basho/machi/pull/35/files#diff-84643a086b4e4b105b74001aa044e0ffR130
- https://github.com/basho/machi/blob/master/test/machi_pb_high_client_test.erl#L67-L69
ETS tables owned by file proxy processes are not closed
read_args uses offset(), which likely reterns < 1024

From PR #35 - Are filenames in PB high clients string()? - https://github.com/basho/machi/pull/35/files#diff-84643a086b4e4b105b74001aa044e0ffR130 - https://github.com/basho/machi/blob/master/test/machi_pb_high_client_test.erl#L67-L69 - ETS tables owned by file proxy processes are not closed - read_args uses offset(), which likely reterns < 1024

kuenishi commented

2015-11-06 01:04:39 +00:00

(Migrated from github.com)

Thank you for opening up. So...

I'm thinking of writing client-facing API with all semantics decided - where I want to clarify it too.
I'm working on ETS tables issue as well as adding tests on file_proxy restart
This is easy to address, will do

Thank you for opening up. So... - I'm thinking of writing client-facing API with all semantics decided - where I want to clarify it too. - [I'm working on ETS tables issue](https://github.com/basho/machi/tree/ku/file-reopen) as well as adding tests on file_proxy restart - This is easy to address, will do