greg/machi
1
0
Fork 0
Code Issues 11 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Review & merge slf/doc-name-game2 #50

Merged
slfritchie merged 12 commits from slf/doc-name-game2 into master 2015-12-09 00:45:11 +00:00
Conversation 5 Commits 12 Files changed 18 +510 -212
slfritchie commented 2015-12-04 06:23:28 +00:00 (Migrated from github.com)
Copy link

This is a hodge-podge PR.

  1. Docs clarification, especially name-game-sketch.org
  2. Small PB definition changes.
  3. Add CoC namespace and locator args to high & low PB APIs.

Unit tests are passing for me (with exception of rare repair EQC test failure (doublewrite_diff,which is known problem)), and dialyzer output appears to be clean.

This is a hodge-podge PR. 1. Docs clarification, especially `name-game-sketch.org` 2. Small PB definition changes. 3. Add CoC namespace and locator args to high & low PB APIs. Unit tests are passing for me (with exception of rare repair EQC test failure (`doublewrite_diff`,which is known problem)), and dialyzer output appears to be clean.
kuenishi commented 2015-12-08 08:09:28 +00:00 (Migrated from github.com)
Copy link

There seems to be no changes in low level PB APIs while it is mentioned in this pull request summary. My question is in what client routing is being done? I thought it was to be at flu proxy client. But Flu server also have to be aware of locator and namespaces, to make sure file names are unique?

There seems to be no changes in low level PB APIs while it is mentioned in this pull request summary. My question is in what client routing is being done? I thought it was to be at flu proxy client. But Flu server also have to be aware of locator and namespaces, to make sure file names are unique?
slfritchie commented 2015-12-08 08:24:09 +00:00 (Migrated from github.com)
Copy link

Short answer: there is no client routing yet ... it still needs writing.

There is a change in the LL part of the PB protocol: https://github.com/basho/machi/pull/50/files#diff-310df0484f27882f8d9a22ac5b041a1eL379. It's quite possible that I have overlooked something in the LL client library, though?

Short answer: there is no client routing yet ... it still needs writing. There is a change in the LL part of the PB protocol: https://github.com/basho/machi/pull/50/files#diff-310df0484f27882f8d9a22ac5b041a1eL379. It's quite possible that I have overlooked something in the LL client library, though?
kuenishi commented 2015-12-08 08:27:08 +00:00 (Migrated from github.com)
Copy link

Umm sorry! My eyes were just holes and not reading anything.

Umm sorry! My eyes were just holes and not reading anything.
jadeallenx commented 2015-12-08 21:46:15 +00:00 (Migrated from github.com)
Copy link

I haven't tested this yet. I just wanted to read through the code and get a feel for the changes. I didn't see anything that struck me as crazy though.

I haven't tested this yet. I just wanted to read through the code and get a feel for the changes. I didn't see anything that struck me as crazy though.
jadeallenx commented 2015-12-08 22:40:17 +00:00 (Migrated from github.com)
Copy link

👍

tests pass and dialyzer looks clean.

:+1: tests pass and dialyzer looks clean.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: greg/machi#50
No description provided.
Delete branch "slf/doc-name-game2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?