LevelDB introduction

kuenishi commented

2015-12-04 08:54:10 +00:00

(Migrated from github.com)

Recently we have admitted we need a simple persistent metadata store in each flu server. Maybe it could be used for other places, but for now it just replaces checksum table only.

This pull request may include several new test failures.

This pull request won't include no new feature, nor fix to known bugs.

Recently we have admitted we need a simple persistent metadata store in each flu server. Maybe it could be used for other places, but for now it just replaces checksum table only. This pull request may include several new test failures. This pull request won't include no new feature, nor fix to known bugs. Related work: https://github.com/basho/sext/pull/2

slfritchie commented

2015-12-07 01:11:08 +00:00

(Migrated from github.com)

Hrm, I'm seeing three eunit test failures at commit 18cb14f6c9403edec2c847bc28c739f8ac1ed5bf

machi_pb_high_client_test

machi_pb_high_client_test: smoke_test_ (module 'machi_pb_high_client_test')...failed
in function machi_pb_high_client_test:'-smoke_test2/0-fun-4-'/2 (test/machi_pb_high_client_test.erl, line 125)
in call from machi_pb_high_client_test:'-smoke_test2/0-lc$^8/1-11-'/2 (test/machi_pb_high_client_test.erl, line 124)
in call from machi_pb_high_client_test:smoke_test2/0 (test/machi_pb_high_client_test.erl, line 122)
**error:{assertEqual_failed,[{module,machi_pb_high_client_test},
{line,125},
{expression,"file : list_dir ( filename : join ( [ Dir , "data" ] ) )"},
{expected,{ok,[]}},
{value,{ok,["prefix^3643d878-1b7a-4f9a-98c5-7244cc760074^1"]}}]}
machi_markle_tree_test:

machi_merkle_tree_test: basic_test (module 'machi_merkle_tree_test')...failed
in function machi_merkle_tree_test:'-basic_test/0-fun-1-'/3 (test/machi_merkle_tree_test.erl, line 45)
**error:{assertEqual_failed,[{module,machi_merkle_tree_test},
{line,45},
{expression,"length ( machi_merkle_tree : naive_diff ( T1 , T2 ) )"},
{expected,1},
{value,8}]}
machi_ap_repair_eqc: known bug (#43)

Also, there are several Dialyzer warnings to clean up. ^_^

Hrm, I'm seeing three eunit test failures at commit 18cb14f6c9403edec2c847bc28c739f8ac1ed5bf - machi_pb_high_client_test machi_pb_high_client_test: smoke_test_ (module 'machi_pb_high_client_test')..._failed_ in function machi_pb_high_client_test:'-smoke_test2/0-fun-4-'/2 (test/machi_pb_high_client_test.erl, line 125) in call from machi_pb_high_client_test:'-smoke_test2/0-lc$^8/1-11-'/2 (test/machi_pb_high_client_test.erl, line 124) in call from machi_pb_high_client_test:smoke_test2/0 (test/machi_pb_high_client_test.erl, line 122) **error:{assertEqual_failed,[{module,machi_pb_high_client_test}, {line,125}, {expression,"file : list_dir ( filename : join ( [ Dir , \"data\" ] ) )"}, {expected,{ok,[]}}, {value,{ok,["prefix^3643d878-1b7a-4f9a-98c5-7244cc760074^1"]}}]} - machi_markle_tree_test: machi_merkle_tree_test: basic_test (module 'machi_merkle_tree_test')..._failed_ in function machi_merkle_tree_test:'-basic_test/0-fun-1-'/3 (test/machi_merkle_tree_test.erl, line 45) **error:{assertEqual_failed,[{module,machi_merkle_tree_test}, {line,45}, {expression,"length ( machi_merkle_tree : naive_diff ( T1 , T2 ) )"}, {expected,1}, {value,8}]} - machi_ap_repair_eqc: known bug (#43) Also, there are several Dialyzer warnings to clean up. ^_^

slfritchie commented

2015-12-07 01:12:36 +00:00

(Migrated from github.com)

I think that failing test 2, in machi_markle_tree_test.erl, is a separate, non-deterministic problem. I'll open a ticket about that.

kuenishi commented

2015-12-07 04:11:57 +00:00

(Migrated from github.com)

Fixed all tests except double write one, but dialyzer check is still failing.

kuenishi commented

2015-12-07 05:56:49 +00:00

(Migrated from github.com)

Scott, I've fixed all test failures. This is ready again and thank you for initial review. btw I haven't seen any test failure around merkle trees.

kuenishi commented

2015-12-08 05:35:45 +00:00

(Migrated from github.com)

todo later:

Currently one instance per file: tie them up to single one per Flu.
Integrate file name registry into LevelDB

todo later: - Currently one instance per file: tie them up to single one per Flu. - Integrate file name registry into LevelDB

slfritchie commented

2015-12-08 07:04:47 +00:00

(Migrated from github.com)

Currently one instance per file: tie them up to single one per Flu

We'll have some file handle sharing limitations to work around, but yes, we should be thinking about that.

Meanwhile, +1, many thanks!

> Currently one instance per file: tie them up to single one per Flu We'll have some file handle sharing limitations to work around, but yes, we should be thinking about that. Meanwhile, +1, many thanks!

LevelDB introduction #51