greg/machi
1
0
Fork 0
Code Issues 11 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Add surface of trim chunks to scrub #8

Merged
kuenishi merged 3 commits from ku/trim-high-proto into master 2015-10-14 03:45:07 +00:00
Conversation 4 Commits 3 Files changed 6 +108 -4
kuenishi commented 2015-10-13 08:34:07 +00:00 (Migrated from github.com)
Copy link

This pull request adds a gate to trim chunks. We had several discussions on "fill" API of CORFU but for now this is just for trim.

This pull request adds a gate to trim chunks. We had several discussions on "fill" API of CORFU but for now this is just for trim.
jadeallenx commented 2015-10-13 14:37:33 +00:00 (Migrated from github.com)
Copy link

Nice start Kota 🍰

Nice start Kota :cake:
kuenishi commented 2015-10-14 00:55:10 +00:00 (Migrated from github.com)
Copy link

@slfritchie Do you think is it OK to merge for now? To avoid conflict against Mark's #6, I'd like to touch machi_flu1 after this got merged.

@slfritchie Do you think is it OK to merge for now? To avoid conflict against Mark's #6, I'd like to touch machi_flu1 after this got merged.
slfritchie commented 2015-10-14 03:31:20 +00:00 (Migrated from github.com)
Copy link

Kota: one small typo to fix, then +1, merge it, many thanks!

Kota: one small typo to fix, then +1, merge it, many thanks!
kuenishi commented 2015-10-14 03:45:12 +00:00 (Migrated from github.com)
Copy link

YW and thanks!

YW and thanks!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: greg/machi#8
No description provided.
Delete branch "ku/trim-high-proto"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?