greg/mentat
1
0
Fork 0
Code Issues 294 Pull requests Projects Releases 9 Packages Wiki Activity

Review comment: style nits.

Browse source
This commit is contained in:
Nick Alexander 2016-10-13 20:37:10 -07:00
parent 39c909ec32
commit 885a816812
1 changed files with 7 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/common/datomish/transact.cljc
View file

@ -350,19 +350,16 @@
:entities - not :db/add, or no id-literals." :entities - not :db/add, or no id-literals."
{:pre [(sequential? entity)]} {:pre [(sequential? entity)]}
(let [[op e a v] entity (let [[op e a v] entity
e? (id-literal? e)
a? (id-literal? a)
v? (id-literal? v)] v? (id-literal? v)]
(cond (when (id-literal? a)
(not= (first entity) :db/add) ;; TODO: verify no id-literals appear.
:entities
a?
(raise "id-literal attributes are not yet supported: " entity (raise "id-literal attributes are not yet supported: " entity
{:error :transact/no-id-literal-attributes {:error :transact/no-id-literal-attributes
:entity entity }) :entity entity }))
(cond
(not= op :db/add) ;; TODO: verify no id-literals appear.
:entities
e? (id-literal? e)
(if (unique-identity? a) (if (unique-identity? a)
(if v? (if v?
:upserts-ev :upserts-ev
@ -383,7 +380,7 @@
Returns a map of id-literals to integer entids, with keys only those id-literals that mapped to Returns a map of id-literals to integer entids, with keys only those id-literals that mapped to
existing entities." existing entities."
(go-pair (go-pair
(if (seq upserts-e) (when (seq upserts-e)
(let [->id-av (fn [[op id-literal a v]] [id-literal [a v]]) (let [->id-av (fn [[op id-literal a v]] [id-literal [a v]])
;; Like {[id-literal [[:a1 :v1] [:a2 :v2] ...]] ...}. ;; Like {[id-literal [[:a1 :v1] [:a2 :v2] ...]] ...}.
id->avs (util/group-by-kv ->id-av upserts-e) id->avs (util/group-by-kv ->id-av upserts-e)