greg/mentat
1
0
Fork 0
Code Issues 294 Pull requests Projects Releases 9 Packages Wiki Activity

Flip ValueRc to Arc in order to allow TypedValue in errors. (#677) (#678) r=rnewman

Browse source 
@mmacedoeu did a good deal of work to show that Arc instead of Rc
wasn't too difficult in #656, and @rnewman pushed the refactoring
across the line in #659. However, we didn't flip the switch at that
time. For #673, we'd like to include TypedValue instances in errors,
and with error-chain (and failure) error types need to be 'Sync +
'Send, so we need Arc.

This builds on #659 and should also finish #656.
This commit is contained in:
Nick Alexander 2018-05-03 16:46:49 -07:00 committed by Richard Newman
parent 1b66818ac9
commit 90465ae74a
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/src/types.rs
View file

@ -121,7 +121,7 @@ impl<T: Clone> Cloned<T> for Box<T> where T: Sized + Clone {
/// This type must implement `FromRc` and `Cloned`, and a `From` implementation must exist for /// This type must implement `FromRc` and `Cloned`, and a `From` implementation must exist for
/// `TypedValue`. /// `TypedValue`.
/// ///
pub type ValueRc<T> = Rc<T>; pub type ValueRc<T> = Arc<T>;
/// Represents one entid in the entid space. /// Represents one entid in the entid space.
/// ///