greg/mentat
1
0
Fork 0
Code Issues 294 Pull requests Projects Releases 9 Packages Wiki Activity

Part 2: instants never matches integers in queries.

Browse source
This commit is contained in:
Richard Newman 2017-04-28 11:27:47 -07:00
parent 2b53abbd85
commit abf625775f
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
core/src/lib.rs
View file

@ -208,6 +208,8 @@ impl SQLValueType for ValueType {
/// ///
/// ``` /// ```
/// use mentat_core::{ValueType, SQLValueType}; /// use mentat_core::{ValueType, SQLValueType};
/// assert!(!ValueType::Instant.accommodates_integer(1493399581314));
/// assert!(!ValueType::Instant.accommodates_integer(1493399581314000));
/// assert!(ValueType::Boolean.accommodates_integer(1)); /// assert!(ValueType::Boolean.accommodates_integer(1));
/// assert!(!ValueType::Boolean.accommodates_integer(-1)); /// assert!(!ValueType::Boolean.accommodates_integer(-1));
/// assert!(!ValueType::Boolean.accommodates_integer(10)); /// assert!(!ValueType::Boolean.accommodates_integer(10));
@ -216,7 +218,8 @@ impl SQLValueType for ValueType {
fn accommodates_integer(&self, int: i64) -> bool { fn accommodates_integer(&self, int: i64) -> bool {
use ValueType::*; use ValueType::*;
match *self { match *self {
Instant | Long | Double => true, Instant => false, // Always use #inst.
Long | Double => true,
Ref => int >= 0, Ref => int >= 0,
Boolean => (int == 0) || (int == 1), Boolean => (int == 0) || (int == 1),
ValueType::String => false, ValueType::String => false,