greg/mentat
1
0
Fork 0
Code Issues 294 Pull requests Projects Releases 9 Packages Wiki Activity

Add note about linked lists data type choice for edn::Value

Browse source
This commit is contained in:
Victor Porof 2017-02-02 16:15:25 +01:00
parent 00048d1955
commit cc56cec11a
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
edn/src/types.rs
View file

@ -33,6 +33,9 @@ pub enum Value {
Keyword(symbols::Keyword), Keyword(symbols::Keyword),
NamespacedKeyword(symbols::NamespacedKeyword), NamespacedKeyword(symbols::NamespacedKeyword),
Vector(Vec<Value>), Vector(Vec<Value>),
// We're using a LinkedList here instead of a Vec or VecDeque because the
// LinkedList is faster for appending (which we do a lot of).
// See https://github.com/mozilla/mentat/issues/231
List(LinkedList<Value>), List(LinkedList<Value>),
// We're using BTree{Set, Map} rather than Hash{Set, Map} because the BTree variants // We're using BTree{Set, Map} rather than Hash{Set, Map} because the BTree variants
// implement Hash. The Hash variants don't in order to preserve O(n) hashing // implement Hash. The Hash variants don't in order to preserve O(n) hashing