[tx] Optimize representation of idents and ident->entid maps #106

New issue

Open

opened 2020-08-06 16:54:59 +00:00 by gburd · 0 comments

gburd commented

2020-08-06 16:54:59 +00:00

(Migrated from github.com)

There's a lot possible here, but let's start by linking to @rnewman's comments about interning idents in https://github.com/mozilla/mentat/issues/32 and at https://github.com/mozilla/mentat/pull/171#discussion_r97211884, and his comment about sparse array maps at https://github.com/mozilla/mentat/pull/171#discussion_r97212893.

Generally, I think a good second iteration will be using https://github.com/servo/string-cache for idents and using a sparse map for entid lookups.

This is not a [good first bug], and it's probably not even a [good next bug].

After #170, we will represent a schema as three maps: ident->entid, the inverse, and entid->schema attributes. This ticket tracks optimizing the representation of idents and ensuring the entid look-ups are fast. There's a lot possible here, but let's start by linking to @rnewman's comments about interning idents in https://github.com/mozilla/mentat/issues/32 and at https://github.com/mozilla/mentat/pull/171#discussion_r97211884, and his comment about sparse array maps at https://github.com/mozilla/mentat/pull/171#discussion_r97212893. Generally, I think a good second iteration will be using https://github.com/servo/string-cache for idents and using a sparse map for entid lookups. This is not a _[good first bug]_, and it's probably not even a _[good next bug]_.