[tx] Extract Error enums from `db/src/errors.rs` #148

New issue

Open

opened 2020-08-06 16:55:44 +00:00 by gburd · 0 comments

gburd commented

2020-08-06 16:55:44 +00:00

(Migrated from github.com)

Per the discussion in https://github.com/mozilla/mentat/issues/366#issuecomment-287717624, error-chain has real problems with lots of error cases. This ticket tracks implementing the approach discussed in https://github.com/mozilla/mentat/issues/366#issuecomment-287809779:

extract various fine-grained Error enums from the errors secion in db/src/errors.rs;
use those in a small number of errors
This is just not something I've gotten to.

I anticipate:

DB related errors (basically, rusqlite errors);
schema related errors
tx parsing errors
transacting errors

In the interim, just overload NotImplementedError.

Per the discussion in https://github.com/mozilla/mentat/issues/366#issuecomment-287717624, `error-chain` has real problems with lots of `error` cases. This ticket tracks implementing the approach discussed in https://github.com/mozilla/mentat/issues/366#issuecomment-287809779: - extract various fine-grained `Error` enums from the `errors` secion in `db/src/errors.rs`; - use those in a small number of `errors` This is just not something I've gotten to. I anticipate: - DB related errors (basically, `rusqlite` errors); - schema related errors - tx parsing errors - transacting errors In the interim, just overload `NotImplementedError`.