[query] Intern query arguments #159

New issue

Open

opened 2020-08-06 16:55:56 +00:00 by gburd · 0 comments

gburd commented

2020-08-06 16:55:56 +00:00

(Migrated from github.com)

Right now we'll happily generate multiple SQL arguments for a query like

[:find ?y ?x :where
 [?x :foo/bar "Thing"]
 [?y :foo/bar "Thing"]]

We should consider interning (giving us a smaller memory footprint) and using shared Rcs when collecting arguments or — better — recognizing duplicate values during query translation and spitting out the same named SQLite argument place ($v0) for both of those.

Right now we'll happily generate multiple SQL arguments for a query like ``` [:find ?y ?x :where [?x :foo/bar "Thing"] [?y :foo/bar "Thing"]] ``` We should consider interning (giving us a smaller memory footprint) and using shared `Rc`s when collecting arguments or — better — recognizing duplicate values during query translation and spitting out the same named SQLite argument place (`$v0`) for both of those.