Correctly expand type code conditions in ground #171

New issue

Open

opened 2020-08-06 16:56:07 +00:00 by gburd · 0 comments

gburd commented

2020-08-06 16:56:07 +00:00

(Migrated from github.com)

At present we record the types of bindings, but if they're not already known, we don't impose an additional constraint. That leaves us with SQL like:

SELECT DISTINCT `all_datoms00`.e AS `?x` FROM `all_datoms` AS `all_datoms00`
WHERE NOT EXISTS (SELECT 1 WHERE `all_datoms00`.v = 5)

which is incorrect — the input was TypedValue::Long(5), but this will reject the fifth FTS string, entity ID 5, a moment in January 1970, and so on.

At present we _record_ the types of bindings, but if they're not already known, we don't impose an additional constraint. That leaves us with SQL like: ```sql SELECT DISTINCT `all_datoms00`.e AS `?x` FROM `all_datoms` AS `all_datoms00` WHERE NOT EXISTS (SELECT 1 WHERE `all_datoms00`.v = 5) ``` which is incorrect — the input was `TypedValue::Long(5)`, but this will reject the fifth FTS string, entity ID 5, a moment in January 1970, and so on.