[tx] Consider using `cache` module for resolving lookup-refs and upserts in transactor #235

New issue

Open

opened 2020-08-06 16:57:06 +00:00 by gburd · 0 comments

gburd commented

2020-08-06 16:57:06 +00:00

(Migrated from github.com)

Long after the initial transactor implementation was set down, Mentat grew a nice cache abstraction; it's in https://github.com/mozilla/mentat/blob/master/db/src/cache.rs. The transactor does a few things right now that are "hand rolled": resolving lookup-refs and upserts. Both of those could be expressed as populating caches from [a v] to e. It might be nice to unify on the cache abstraction more generally, minimizing hand rolled SQL queries and special purpose munging.

Long after the initial transactor implementation was set down, Mentat grew a nice cache abstraction; it's in https://github.com/mozilla/mentat/blob/master/db/src/cache.rs. The transactor does a few things right now that are "hand rolled": resolving lookup-refs and upserts. Both of those could be expressed as populating caches from `[a v]` to `e`. It might be nice to unify on the cache abstraction more generally, minimizing hand rolled SQL queries and special purpose munging.