From 42e4296b043b5ed7abdaa42ee3223a55b69e43eb Mon Sep 17 00:00:00 2001 From: Michael Whittaker Date: Sun, 31 Jan 2021 17:47:35 -0800 Subject: [PATCH] Added some TODOs to Expr. Right now, there is not a nice way to check that two expressions are equal. It would be fun to implement this, though it may not be super fast. --- quorums/expr.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/quorums/expr.py b/quorums/expr.py index 6363a5a..f2c11f7 100644 --- a/quorums/expr.py +++ b/quorums/expr.py @@ -55,6 +55,12 @@ class Expr(Generic[T]): def quorums(self) -> Iterator[Set[T]]: raise NotImplementedError + # TODO(mwhittaker): Add a function to return minimal quorums. + + # TODO(mwhittaker): Add a function to check whether two expressions are + # equal. One simple way to do this is compare the set of minimal quorums. + # There might be more efficient ways to check if two expressions are equal. + def is_quorum(self, xs: Set[T]) -> bool: raise NotImplementedError