greg/quoracle
1
0
Fork 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Fixes for type check errors exposed by pyright #6

Merged
adsharma merged 1 commit from typing_fixes into main 2021-04-11 01:29:46 +00:00
Conversation 5 Commits 1 Files changed 6 +37 -33
adsharma commented 2021-04-03 17:46:08 +00:00 (Migrated from github.com)
Copy link

Use SupportsLessThan to indicate that TypeVar T should be
comparable.

Use SupportsLessThan to indicate that TypeVar T should be comparable.
mwhittaker commented 2021-04-05 17:04:28 +00:00 (Migrated from github.com)
Copy link

Wow, this is great! I've been targeting Python 3.6, and I think the Protocol stuff is a newer feature? Could we split out the Python 3.6 compatible stuff from the non Python 3.6 compatible stuff? I'd love to merge as much of this as possible. Or maybe, we should just require a newer Python version? I'm not sure, what do you think?

Wow, this is great! I've been targeting Python 3.6, and I think the Protocol stuff is a newer feature? Could we split out the Python 3.6 compatible stuff from the non Python 3.6 compatible stuff? I'd love to merge as much of this as possible. Or maybe, we should just require a newer Python version? I'm not sure, what do you think?
adsharma commented 2021-04-05 18:47:39 +00:00 (Migrated from github.com)
Copy link

Protocols are python3.8, created in 2017, accepted in 2019.

https://www.python.org/dev/peps/pep-0544/

I believe backports are available via:

https://pypi.org/project/typing-extensions/

Protocols are python3.8, created in 2017, accepted in 2019. https://www.python.org/dev/peps/pep-0544/ I believe backports are available via: https://pypi.org/project/typing-extensions/
adsharma commented 2021-04-05 18:52:29 +00:00 (Migrated from github.com)
Copy link

My general preference is to avoid python2, support python releases from 2-4 years ago. python3.6 was released Dec 2016.

Alternatively, you can target the python versions in the "long term supported" largest/popular linux distributions: ubuntu 18.04 (3.6) and 20.04 (3.8) as of today.

My general preference is to avoid python2, support python releases from 2-4 years ago. python3.6 was released Dec 2016. Alternatively, you can target the python versions in the "long term supported" largest/popular linux distributions: ubuntu 18.04 (3.6) and 20.04 (3.8) as of today.
mwhittaker commented 2021-04-11 01:34:22 +00:00 (Migrated from github.com)
Copy link

Got it. I updated to Python 3.8 and merged this in! Thanks again for the pull request. I really appreciate you checking out the repo and improving it :)

Got it. I updated to Python 3.8 and merged this in! Thanks again for the pull request. I really appreciate you checking out the repo and improving it :)
mwhittaker commented 2021-04-11 01:43:41 +00:00 (Migrated from github.com)
Copy link

Fixes #4.

Fixes #4.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: greg/quoracle#6
No description provided.
Delete branch "typing_fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?