greg/stasis-aries-wal
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Changed malloc() to calloc() to prevent unpacked structs from leaking

Browse source 
bytes to log
This commit is contained in:
Sears Russell 2007-03-03 23:24:00 +00:00
parent ca57875007
commit 2d3fc4ba47
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/lladd/logger/logEntry.c
View file

@ -83,7 +83,11 @@ LogEntry * allocUpdateLogEntry(lsn_t prevLSN, int xid,
const byte * args, unsigned int argSize, const byte * preImage) { const byte * args, unsigned int argSize, const byte * preImage) {
int invertible = operationsTable[funcID].undo != NO_INVERSE; int invertible = operationsTable[funcID].undo != NO_INVERSE;
int whole_page_phys = operationsTable[funcID].undo == NO_INVERSE_WHOLE_PAGE; int whole_page_phys = operationsTable[funcID].undo == NO_INVERSE_WHOLE_PAGE;
LogEntry * ret = malloc(sizeof(struct __raw_log_entry) + sizeof(UpdateLogEntry) + argSize +
/** Use calloc since the struct might not be packed in memory;
otherwise, we'd leak uninitialized bytes to the log. */
LogEntry * ret = calloc(1, sizeof(struct __raw_log_entry) + sizeof(UpdateLogEntry) + argSize +
((!invertible) ? physical_slot_length(rid.size) : 0) + (whole_page_phys ? PAGE_SIZE : 0)); ((!invertible) ? physical_slot_length(rid.size) : 0) + (whole_page_phys ? PAGE_SIZE : 0));
ret->LSN = -1; ret->LSN = -1;
ret->prevLSN = prevLSN; ret->prevLSN = prevLSN;