greg/stasis-aries-wal
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed memory leak during analysis phase.

Browse source
This commit is contained in:
Sears Russell 2008-03-01 19:27:31 +00:00
parent 673f6b55d3
commit 4c83e1c373
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/stasis/recovery2.c
View file

@ -102,7 +102,7 @@ static void Analysis () {
/* We've removed this XACT's last LSN from the list of LSN's to
be rolled back, so we're done. */
break;
case XEND:
case XEND: {
/*
XEND means this transaction reached stable storage.
Therefore, we can skip redoing any of its operations. (The
@ -113,7 +113,10 @@ static void Analysis () {
transactionLSN before redoing its actions. Therefore, if we
remove this transaction from the hash, it will not be redone.
*/
pblHtRemove(transactionLSN, &(e->xid), sizeof(int));
lsn_t* free_lsn = pblHtLookup(transactionLSN, &(e->xid), sizeof(int));
pblHtRemove(transactionLSN, &(e->xid), sizeof(int));
free(free_lsn);
}
break;
case UPDATELOG:
case CLRLOG:
@ -288,8 +291,11 @@ void InitiateRecovery() {
Undo(1);
DEBUG("Recovery complete.\n");
for(void * it = pblHtFirst(transactionLSN); it; it = pblHtNext(transactionLSN)) {
free(pblHtCurrent(transactionLSN));
}
pblHtDelete(transactionLSN);
destroyList(&rollbackLSNs);
assert(rollbackLSNs==0);
}