greg/stasis-aries-wal
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix race in TallocFromPage()

Browse source
This commit is contained in:
Sears Russell 2006-08-11 00:01:12 +00:00
parent 73436d0d6c
commit 51c5b60047
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/lladd/operations/alloc.c
View file

@ -167,6 +167,7 @@ static void reserveNewRegion(int xid) {
next->pageid = firstPage + i;
next->freespace = initialFreespace;
next->lockCount = 0;
newPages[i] = next;
TinitializeSlottedPage(xid, firstPage + i);
}
@ -249,9 +250,12 @@ void allocTransactionCommit(int xid) {
}
compensated_function recordid TallocFromPage(int xid, long page, unsigned long size) {
pthread_mutex_lock(&talloc_mutex);
Page * p = loadPage(xid, page);
recordid ret = TallocFromPageInternal(xid, p, size);
releasePage(p);
pthread_mutex_unlock(&talloc_mutex);
return ret;
}
@ -319,15 +323,22 @@ compensated_function void Tdealloc(int xid, recordid rid) {
void * preimage = malloc(rid.size);
Page * p;
pthread_mutex_lock(&talloc_mutex);
try {
p = loadPage(xid, rid.page);
} end;
allocationPolicyLockPage(allocPolicy, xid, rid.page); // XXX shouldn't this do something with dereferenceRid()?!?
begin_action(releasePage, p) {
readRecord(xid, p, rid, preimage);
/** @todo race in Tdealloc; do we care, or is this something that the log manager should cope with? */
Tupdate(xid, rid, preimage, OPERATION_DEALLOC);
} compensate;
pthread_mutex_unlock(&talloc_mutex);
free(preimage);
}
compensated_function int TrecordType(int xid, recordid rid) {