greg/stasis-aries-wal
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed a performance bug that was causing logical operations to unnecessarily pin pages.

Browse source
This commit is contained in:
Sears Russell 2006-10-05 22:05:50 +00:00
parent a3e3ad2453
commit 71f51d11bc
1 changed files with 27 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
src/lladd/operations.c
View file

@ -66,10 +66,16 @@ void redoUpdate(const LogEntry * e) {
/* lsn_t pageLSN = readLSN(e->contents.update.rid.page); */ /* lsn_t pageLSN = readLSN(e->contents.update.rid.page); */
recordid rid = e->contents.update.rid; recordid rid = e->contents.update.rid;
Page * p; Page * p;
lsn_t pageLSN;
try { try {
if(operationsTable[e->contents.update.funcID].sizeofData == SIZEIS_PAGEID) {
p = NULL;
pageLSN = 0;
} else {
p = loadPage(e->xid, rid.page); p = loadPage(e->xid, rid.page);
pageLSN = pageReadLSN(p);
}
} end; } end;
lsn_t pageLSN = pageReadLSN(p);
if(e->LSN > pageLSN) { if(e->LSN > pageLSN) {
DEBUG("OPERATION Redo, %ld > %ld {%d %d %ld}\n", e->LSN, pageLSN, rid.page, rid.slot, rid.size); DEBUG("OPERATION Redo, %ld > %ld {%d %d %ld}\n", e->LSN, pageLSN, rid.page, rid.slot, rid.size);
@ -82,25 +88,35 @@ void redoUpdate(const LogEntry * e) {
} else { } else {
DEBUG("OPERATION Skipping redo, %ld <= %ld {%d %d %ld}\n", e->LSN, pageLSN, rid.page, rid.slot, rid.size); DEBUG("OPERATION Skipping redo, %ld <= %ld {%d %d %ld}\n", e->LSN, pageLSN, rid.page, rid.slot, rid.size);
} }
if(p) {
releasePage(p); releasePage(p);
}
} else if(e->type == CLRLOG) { } else if(e->type == CLRLOG) {
const LogEntry * f = LogReadLSN(e->contents.clr.thisUpdateLSN); const LogEntry * f = LogReadLSN(e->contents.clr.thisUpdateLSN);
recordid rid = f->contents.update.rid; recordid rid = f->contents.update.rid;
Page * p = NULL; Page * p = NULL;
lsn_t pageLSN;
int isNullRid = !memcmp(&rid, &NULLRID, sizeof(recordid)); int isNullRid = !memcmp(&rid, &NULLRID, sizeof(recordid));
if(!isNullRid) { if(!isNullRid) {
if(operationsTable[f->contents.update.funcID].sizeofData == SIZEIS_PAGEID) {
p = NULL;
pageLSN = 0;
} else {
try { try {
p = loadPage(e->xid, rid.page); p = loadPage(e->xid, rid.page);
pageLSN = pageReadLSN(p);
} end; } end;
} }
}
//assert(rid.page == e->contents.update.rid.page); /* @todo Should this always hold? */ //assert(rid.page == e->contents.update.rid.page); /* @todo Should this always hold? */
/* See if the page contains the result of the undo that this CLR is supposed to perform. If it /* See if the page contains the result of the undo that this CLR
doesn't, then undo the original operation. */ is supposed to perform. If it doesn't, or this was a logical
operation, then undo the original operation. */
if(isNullRid || f->LSN > pageReadLSN(p)) {
if(isNullRid || f->LSN > pageLSN) {
DEBUG("OPERATION Undoing for clr, %ld {%d %d %ld}\n", f->LSN, rid.page, rid.slot, rid.size); DEBUG("OPERATION Undoing for clr, %ld {%d %d %ld}\n", f->LSN, rid.page, rid.slot, rid.size);
undoUpdate(f, p, e->LSN); undoUpdate(f, p, e->LSN);