greg/xv6
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

my comment is wrong, exec handles BSS fine

Browse source
This commit is contained in:
Robert Morris 2010-09-19 13:47:52 -04:00
parent 4587b35847
commit 05d66b0629
2 changed files with 16 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
exec.c
View file

@ -48,9 +48,6 @@ exec(char *path, char **argv)
}
iunlockput(ip);
// XXX rtm: what about the BSS? shouldn't there be some
// bzero()ing here?
// Allocate and initialize stack at sz
sz = spbottom = PGROUNDUP(sz);
if(!(sz = allocuvm(pgdir, sz, sz + PGSIZE)))

16
usertests.c
View file

@ -1419,6 +1419,21 @@ validatetest(void)
printf(stdout, "validate ok\n");
}
char uninit[10000];
void
bsstest(void)
{
int i;
printf(stdout, "bss test\n");
for(i = 0; i < sizeof(uninit); i++){
if(uninit[i] != '\0'){
printf(stdout, "bss test failed\n");
exit();
}
}
printf(stdout, "bss test ok\n");
}
int
main(int argc, char *argv[])
{
@ -1430,6 +1445,7 @@ main(int argc, char *argv[])
}
close(open("usertests.ran", O_CREATE));
bsstest();
sbrktest();
validatetest();